Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package theora.0.4.1 #26807

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Package theora.0.4.1 #26807

merged 2 commits into from
Oct 29, 2024

Conversation

toots
Copy link
Contributor

@toots toots commented Oct 29, 2024

theora.0.4.1

Bindings to libtheora



🐫 Pull-request generated by opam-publish v2.3.0

"ogg" {>= "0.7.0"}
]
build: [
["dune" "subst"] {pinned}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address the failing CI lint

Warning in theora.0.4.1: Dubious use of 'dune subst'. 'dune subst' should always only be called with {dev} (i.e. ["dune" "subst"] {dev}) If your opam file has been autogenerated by dune, you need to upgrade your dune-project to at least (lang dune 2.7).
Suggested change
["dune" "subst"] {pinned}
["dune" "subst"] {dev}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed and bumped dune version upstream.

Co-authored-by: Shon Feder <shon.feder@gmail.com>
synopsis: "Bindings to libtheora"
maintainer: ["The Savonet Team <savonet-users@lists.sourceforge.net>"]
authors: ["The Savonet Team <savonet-users@lists.sourceforge.net>"]
license: "GPL-2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this before:

I think this is not a big deal for now now, but be we are getting a linting error here because this a deprecated license identifier (see the last section of https://spdx.org/licenses/).

If you can switch to one of the current identifiers in your code base (e.g., GPL-2.0-or-later or GPL-2.0-only) here and/or in your code base, we won't hit this next time you do an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fixed, thanks!

@shonfeder
Copy link
Collaborator

The only CI failure is unrelated to this package (something up with dune on 4.02, I'll investigate).

@shonfeder
Copy link
Collaborator

Thanks for publishing the update!

@shonfeder shonfeder merged commit 6cf7180 into ocaml:master Oct 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants